search

fragglet / vanilla-utilities

Doom engine DOS utilities
https://www.doomworld.com/forum/topic/110970-the-vanilla-utilities/
GNU General Public License v2.0
19 stars 0 forks source link

Files have inconsistent line endings #19

Open turol opened 1 year ago

turol commented 1 year ago

Most files have Unix-style line endings but some have DOS-style line endings. Some examples:

net/doomnet.c:   C source, ASCII text, with CRLF line terminators
net/doomnet.h:   C source, ASCII text, with CRLF line terminators
net/ipxcall.asm: ASCII text
net/ipxcall.h:   C source, ASCII text
net/ipxnet.c:    C source, ASCII text, with CRLF line terminators
net/ipxnet.h:    C source, ASCII text, with CRLF line terminators
net/ipxsetup.c:  C source, ASCII text, with CRLF line terminators
net/metanet.c:   C source, ASCII text
net/parport.c:   C source, ASCII text, with CRLF line terminators
net/parport.h:   ASCII text, with CRLF line terminators
net/parsetup.c:  C source, ASCII text, with CRLF line terminators
net/passthru.c:  C source, ASCII text
net/plio.asm:    ASCII text, with CRLF line terminators
net/serarb.c:    C source, ASCII text, with CRLF line terminators
net/serarb.h:    C source, ASCII text
net/serport.c:   C source, ASCII text, with CRLF line terminators
net/serport.h:   ASCII text, with CRLF line terminators
net/sersetup.c:  C source, ASCII text, with CRLF line terminators
net/solo-net.c:  C source, ASCII text, with CRLF line terminators

There appears to be no rhyme or reason for which is which. For example serarb.h is Unix while serarb.c is DOS.

fragglet commented 1 year ago

Thanks for reporting - they're all supposed to be DOS format but it looks like I forgot to set the right file type on some of the files I've added.

On Wed, 1 Feb 2023 at 08:42, Turo Lamminen @.***> wrote:

Most files have Unix-style line endings but some have DOS-style line endings. Some examples:

net/doomnet.c: C source, ASCII text, with CRLF line terminators net/doomnet.h: C source, ASCII text, with CRLF line terminators net/ipxcall.asm: ASCII text net/ipxcall.h: C source, ASCII text net/ipxnet.c: C source, ASCII text, with CRLF line terminators net/ipxnet.h: C source, ASCII text, with CRLF line terminators net/ipxsetup.c: C source, ASCII text, with CRLF line terminators net/metanet.c: C source, ASCII text net/parport.c: C source, ASCII text, with CRLF line terminators net/parport.h: ASCII text, with CRLF line terminators net/parsetup.c: C source, ASCII text, with CRLF line terminators net/passthru.c: C source, ASCII text net/plio.asm: ASCII text, with CRLF line terminators net/serarb.c: C source, ASCII text, with CRLF line terminators net/serarb.h: C source, ASCII text net/serport.c: C source, ASCII text, with CRLF line terminators net/serport.h: ASCII text, with CRLF line terminators net/sersetup.c: C source, ASCII text, with CRLF line terminators net/solo-net.c: C source, ASCII text, with CRLF line terminators

There appears to be no rhyme or reason for which is which. For example serarb.h is Unix while serarb.c is DOS.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Simon Howard https://soulsphere.org/

turol commented 1 year ago

Why commit with DOS line-endings? It's poorly supported by git (or not at all...). The other way is possible with autocrlf option and actually supported.