search

fragilefamilieschallenge / metadata_app

Front-end for users to access Fragile Families metadata API
http://metadata.fragilefamilies.princeton.edu
MIT License
3 stars 1 forks source link

Added tooltips to search page #43

Closed thartshorne closed 6 years ago

thartshorne commented 6 years ago

issue #32 should be closed, unless we want any aesthetic changes to the tooltips. I tried adding the tooltips to the similar variables table in variable.html, but it caused a weird formatting glitch to occur when I hovered over them.

msalganik commented 6 years ago

@atkindel I believe that you created the original issue. Does this do what you are expecting? If so, please merge the pull request and close the issue.

msalganik commented 6 years ago

@atkindel I believe that you created the original issue. Does this do what you are expecting? If so, please merge the pull request and close the issue.

msalganik commented 6 years ago

@atkindel This is related to an issue that you requested. Can you please review this pull request?

vineetbansal commented 6 years ago

@thartshorne We're displaying the "survey" field instead of the "Respondent" when this pull request was created. Is "Who was asked the question?" a valid description of the "survey" field? If so, I can merge the changes.

thartshorne commented 6 years ago

@vineetbansal Ah, that makes sense but no it is not an accurate description. A more accurate description of survey would be "Which instrument was this from?" while the current description would still apply to respondent.

vineetbansal commented 6 years ago

The tooltips have been incorporated in 3e6e9dcfe00823189bbf9058ba1a2387cef3aedb. Closing this.