search

fragla / eq5d

Other
21 stars 4 forks source link

Feature request: additional information from valuesets() #11

Closed TimTaylor closed 2 years ago

TimTaylor commented 3 years ago

It would be a nice addition to the valuesets() function if it could also return some additional information such as the year (and possibly DOI) of the associated paper.

fragla commented 2 years ago

Yes, agree. This is something I've thought about doing previously (and incorporating into the shiny app). I've got most of the info in the data.R file, I just need to get a few DOIs for some of the book chapters I used and to double check the value set years. Will add before the next release.

TimTaylor commented 2 years ago

@fragla would you be ok if I started working on a minimal PR for this (probably just a column of DOIs). I'm currently working on a package to assist colleagues in modelling qaly losses (https://github.com/TimTaylor/qalytools) and will need to ensure they have correct citations for value sets.

fragla commented 2 years ago

@TimTaylor sure, no problem. Sorry I've not managed to get round to doing this. I've attached a file with DOIs/PubMed IDs/other links that I was part way through pulling together - hopefully this will help. Rather than referencing the EQ-5D books for 3L TTO/VAS value sets as I'd done for type documentation (e.g. in ?TTO) I was going to use the individual manuscript references, but there's still a few to get.

valuesets.csv

TimTaylor commented 2 years ago

Cool. I'll start a draft PR and add to it incrementally. Can then squash / merge as appropriate when finished.

fragla commented 2 years ago

Implemented by #24.