search

fragmenta / query

An SQL query builder for golang
MIT License
41 stars 10 forks source link

Adapter Statement Close #5

Closed badu closed 8 years ago

badu commented 8 years ago

In query/adapters/database.go lines 114 and 141 you have a defer stmt.Close() , despite the fact that you have a comment saying "Caller is responsible for closing rows with defer rows.Close()". This causes runtime errors in fragmenta-cms.

kennygrant commented 8 years ago

Apologies for the delay in responding. defer stmt.Close() is not the same as defer rows.Close() is it? We close the statement, then leave the caller to close the rows. Can you paste in the error you saw?