search

frain-dev / convoy

The Cloud Native Webhooks Gateway
https://getconvoy.io
Other
2.43k stars 135 forks source link

Convoy is not compatible with Redis Sentinel #1842

Open itek09 opened 9 months ago

itek09 commented 9 months ago

Hello everyone.

Right now, I'm deploying Convoy using the official Helm Chart and I tried to use Redis Sentinel to have HA on it, but seems that Convoy is not compatible (even if the Chart suggest 'redis-sentinel' as a valid schema)

If you try to use that schema, the app gives you the next error:

{"level":"info","msg":"convoy.json not detected, will look for env vars or cli args","time":"2023-11-20 13:42:14"}
Error: redis: invalid URL scheme: redis-sentinel
time="2023-11-20T13:42:14Z" level=fatal msg="redis: invalid URL scheme: redis-sentinel"

Would be nice to allow that URL scheme to be able to use Sentinel.

Many thanks!

jirevwe commented 9 months ago

Hey @itek09,

I take full responsibility for this. This is on our roadmap and while we (read I) were adding cluster support, it skipped my mind to add sentinel support, but I did have in mind to add it while I was updating the helm charts. I'll update this issue with the PR that adds it.

itek09 commented 9 months ago

Many thanks! I will keep the issue on track as it would be a nice feature.

Thanks for the fast reply ;)