search

fralalonde / dipstick

Configurable metrics toolkit for Rust applications
Apache License 2.0
99 stars 9 forks source link

Upgrade to Rust 2018 edition #54

Closed Atul9 closed 5 years ago

Atul9 commented 5 years ago

Run cargo fmt to format code Run cargo fix --edition to update crate for rust 2018 Specify edition to 2018 in Cargo.toml closes #47

fralalonde commented 5 years ago

Hey, thanks!

Just one thing: I'm ok with code reformatting but would prefer if it was applied in a separate PR (unless it is required by the 2018 edition ?!). As it is, it is hard to see what changes were specifically performed for the move to the 2018 edition. Reformatting also impacts the other pending PR because it creates merge conflicts - it would be best to apply it when no other PRs are pending. I'll try to merge my stuff in a few hours to clear the path for reformatting.

Atul9 commented 5 years ago

@fralalonde should I update this PR to include only these 2 changes -

  1. Run cargo fix --edition to update crate for rust 2018
  2. Specify edition to 2018 in Cargo.toml
fralalonde commented 5 years ago

Ha! I understand, a single command does everything... including the reformat :( Oh well. Let's just merge this as-is then, unless there is a --no-format option.

fralalonde commented 5 years ago

I will format the code first, then your changes for the rust 2018 should appear in clear.

fralalonde commented 5 years ago

Sorry I broke your PR, you may reapply --fix from the now formatted master branch, the changes should appear way more clearly now in the diff.

Atul9 commented 5 years ago

It's ok. I have updated the PR.

fralalonde commented 5 years ago

Good stuff. Thanks!