search

fralalonde / dipstick

Configurable metrics toolkit for Rust applications
Apache License 2.0
99 stars 9 forks source link

Fails to compile under newest nightly #69

Closed vorner closed 5 years ago

vorner commented 5 years ago

Hello

When trying to compile with today's nightly ($ rustc --version rustc 1.36.0-nightly (d35181ad8 2019-05-20)), the compilation fails with:

error[E0283]: type annotations required: cannot resolve `std::string::String: std::convert::AsRef<_>`
   --> src/output/prometheus.rs:150:41
    |
150 |         match minreq::get(self.push_url.as_ref())
    |

AFAIK this „needs to be more specific“ errors are actually allowed breakage/acceptable exception to the stability promise ☹. So I'm not sure if it's worth reporting to rustc (I'll try it anyway, but it might be worth to add some annotations in dipstick too, just in case).

vorner commented 5 years ago

Ah, seems to be this https://github.com/rust-lang/rust/issues/60958