Unhandled exception when checking if URL exists #101

fralau / mkdocs-mermaid2-plugin

A Mermaid graphs plugin for mkdocs

https://mkdocs-mermaid2.readthedocs.io

MIT License

214 stars 26 forks source link

Unhandled exception when checking if URL exists #101 #102

Closed BansheeHero closed 1 month ago

BansheeHero commented 6 months ago

Handle exceptions raised from the use of requests.exceptions. Implement warning and critical in the style of the original authors: Warning is used for capturing the faulty request. Critical is used to notify user that there is a problem.

I am still leaving the raise FileNotFoundError there as I wanted to make another request for turning this optional.

fralau commented 4 months ago

Please relate this PR to an existing issue, or open one.

BansheeHero commented 4 months ago

Please relate this PR to an existing issue, or open one.

There should be one open already: #101.

fralau commented 4 months ago

The best way to make the link is to indicate, on the right of the pane under "Development", the number of the issue. I did that.

fralau commented 1 month ago

Replaced by commit 2fb1038 (see #101 )