Set version of setuptools dependency to be less than 72

fralau / mkdocs-mermaid2-plugin

A Mermaid graphs plugin for mkdocs

https://mkdocs-mermaid2.readthedocs.io

MIT License

220 stars 28 forks source link

Set version of setuptools dependency to be less than 72 #106

Closed aldman123 closed 4 months ago

aldman123 commented 4 months ago

Setup tools has a breaking version which is causing issues. https://setuptools.pypa.io/en/stable/history.html#v72-0-0

This PR is just to lock the version to be before 72.0.0. A future PR may be needed to migrate to a different test runner.

fralau commented 4 months ago

Thanks! For good measure can I ask you to open as well an issue refering to this PR, so that the problem can be made clear to all?

aldman123 commented 4 months ago

Looks like setuptools is aware of downstream issues and is trying to undo the changes. This PR might not be needed anymore https://setuptools.pypa.io/en/stable/history.html#v72-0-0

aldman123 commented 4 months ago

Looks like the new release (72.1.0) works for my projects. Hopefully no change is needed for the mkdocs-mermaid2-plugin, but ideally a more active contributor should check that things are working as expected.

Feel free to close this PR without merging.

fralau commented 4 months ago

As requested.

fralau commented 4 months ago

@aldman123

ideally a more active contributor should check that things are working as expected.

That would be greatly appreciated. If in the future you notice something, do not hesitate to open an issue again.