search

fralik / Duorem

27 stars 8 forks source link

Guessing broadcast address may go wrong #10

Closed MScMSc closed 6 years ago

MScMSc commented 6 years ago

Ok, this is something of a mixture of "fatal user error", misleading UI and unfortunate coincidences. But maybe some improvements may still come from it:

I configured a device - Name, IP address and MAC address, then saved. Since I believed the IP address wasn't strictly necessary, I entered the dummy 10.10.10.10 address. At that time, I was not connected to my WIFI (I only became aware of that fact later). So the WOL broadcast address was based either on my dummy address, or on the IP address in the 4G network. Of course, WOL did not work in my local network. However, since the broadcast address is hidden in the advanced settings, I did not at first realize what the problem was. After I opened the advanced settings, I quickly realized and corrected my errors.

Some questions and suggestions

  1. Does it make any sense to have a broadcast address in the mobile network (if that was the case)? Should it be possible at all?
  2. Would it make sense to warn the user that no local network is connected?
  3. If that's not an option / not easy to do, I would appreciate a hint upon creating a new device: "Please make sure you are connected to the same network as the target device"
  4. Maybe the broadcast address should not be in the advanced settings?
  5. If I change the IP address in such a way that the broadcast address doesn't match at all (I changed from a 10. to a 192. address), maybe the broadcast address needs to be updated, or the user given some hint to check it.
fralik commented 6 years ago

Thanks for addressing it.

  1. I think it can make sense if one configures wake-over-internet.
  2. There is a notification on the main screen, but when user enters device details it is up to her to either provide all the specifics or to use scanned information. If scanned information is to be used, then there is again a message if network is unavailable.
  3. I reconfigured the layout, so that the broadcast address is not hidden and it is located right below MAC address field.
  4. See 3.
  5. Good point. Have not implemented for version 1.1.1, but the mismatch should now be easy to spot due to 3-4.
fralik commented 6 years ago

Closing due to inactivity and at least partial fix.