frallain / pymsfilereader

Thermo MSFileReader Python bindings
MIT License
67 stars 25 forks source link

GetPrecursorInfoFromScanNum() problem with MSFileReader_3.1SP4_x64 #4

Open pmrotem opened 6 years ago

pmrotem commented 6 years ago

Hi,

Thanks for the code you offer, i took it and added it to my project. For some reason, now my script crashes every now and then. I located the source of the crash to GetPrecursorInfoFromScanNum() function and apparently the script crashes when i tries to touch the VARIANT variable after calling the dll function. The odd thing is that it happens once in a while, i can run it for an hour and it won't crash then run it again and it crashes on start.

Would really appreciate you help, Rotem

frallain commented 6 years ago

Hello,

What version of msfilereader do you use? I recommend trying with a different version of msfilereader, these are just python wrappers to it. You are the first one to signal me this kind of problem. Cheers

On Thursday, October 11, 2018, pmrotem notifications@github.com wrote:

Hi,

Thanks for the code you offer, i took it and added it to my project. For some reason, now my script crashes every now and then. I located the source of the crash to GetPrecursorInfoFromScanNum() function and apparently the script crashes when i tries to touch the VARIANT variable after calling the dll function. The odd thing is that it happens once in a while, i can run it for an hour and it won't crash then run it again and it crashes on start.

Would really appreciate you help, Rotem

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci4.googleusercontent.com/proxy/a-G1Upd5y_uj_UleLeCL7acX0DaNozQ0jD-TMAaxudJmcgjAAzUGFNrDr3Ksj3hn9qseFvmjOpWJXRNbj_JigeXrG2Rg9KJV5kwCVogm3WbgrydFWZ4QoD7gSU8M8ujGLVjYbyfJ2IQlP8j-KhSqJyoIDB8hHA=s0-d-e1-ft#https://github.com/notifications/beacon/AB1Q2i_f0M69OdkQhe-lyVoZu0B3lUKQks5ujvMFgaJpZM4XW7-o.gif

--

François ALLAIN +353 83 470 6341 +33 651399906

pmrotem commented 6 years ago

i'm using MSFileReader_3.1SP4_x64. will try another msfilereader. thanks, Rotem

pmrotem commented 6 years ago

Hi,

i tried 2 other versions, but the same crash still happens. I'm using 64 bit thermo dll and python, maybe switching to 32bit can make a change?

Thanks, Rote,

pmrotem commented 6 years ago

Hi,

Just to let you know, it seems that moving to python 3 32-bit and MSFileReader_3.0SP2.zip 32-bit seems to solve the problem, can't reproduce the crash i had.

Rotem

frallain commented 6 years ago

Interesting thanks, what was the original version of msfilereader? What did you try?

On Wednesday, October 17, 2018, pmrotem notifications@github.com wrote:

Hi,

Just to let you know, it seems that moving to python 3 32-bit and MSFileReader_3.0SP2.zip 32-bit seems to solve the problem, can't reproduce the crash i had.

Rotem

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/frallain/MSFileReader-Python-bindings/issues/4#issuecomment-430600192, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1Q2qQk3JbqUDnmGBxv1sixMwvgfAEfks5ulxvBgaJpZM4XW7-o .

--

François ALLAIN +353 83 470 6341 +33 651399906

pmrotem commented 6 years ago

at first i used MSFileReader_3.1SP4_x64 and python 3.5 64-bit. I tried using other versions of comtypes package, and other msfilereader versions, but only switching to 32-bit seems to solve the issue.

frallain commented 5 years ago

@pmrotem Could you provide your rawfile so that I (or Thermo) can reproduce this bug? It must be a regression bug introduced in version 3.1

frallain commented 5 years ago

Also, have you been trying on the same OS? Which one? Same version of comtypes? Which one? Same version of python? Which one? What are the combinations of MSFileReader-Python versions you tried?

pmrotem commented 5 years ago

Hi,

It is been a long time since then but i'll try the best i can: comtypes - i tried 1.1.7 and maybe some earlier versions os - i tried win10 mostly, i think also tried win7. i encountered this bug on at least 2 different pc's. python 3.6. 32 bit and the 32 bit msfilereader dll i mentioned(which works), but just so you'll know i encountered a memory error with big files due to the 32bit python(the virtual addresses are much smaller) python 3.6. 64 bit and the msfilereader 64bit 2 dll's (i mentioned above).

i can check if i can upload the mzml, but to where (btw, i encountered this error with different files, not only one)? as i told you, this bug is a nasty one, it doesn't happen at the same time and at the same place.

Thanks alot, and i hope this issue will be resolved. Rotem

rexdwyer commented 4 years ago

I'm having the same problem.... python 3.8 64-bit... windows 10 When I call getVersionNumber, I get "66". The size of the DLL file is 263,680 bytes. Maybe that tells you which version. The queer thing is that it causes the program to crash with an Oracle error message, so it took me a heck of a long time to track this down.

ORA-24550: signal received: Unhandled exception: Code=c0000005 Flags=0

Encountered exception while getting args for function:0x00007FFCEEBAD4CC
kpedbg_dmp_stack()+350<-kpeDbgCrash()+123<-kpeDbgSignalHandler()+128<-skgesig_Win_UnhandledExceptionFilter()+164<-00007FFCEB1F6913<-00007FFCEEBAD504<-00007FFCEEB963A6<-00007FFCEEBA9FFD<-00007FFCEEB351C8<-00007FFCEEBA907E<-00007FFCB931F1A0<-00007FFCB9315171<-00007FFCB9318159<-00007FFCB9318910<-00007FFCB9437254<-00007FFCB9420192<-00007FFCB9436907<-00007FFCB9436E73<-00007FFCB9420192<-00007FFCB9436907<-00007FFCB9436E73<-00007FFCB9420192<-00007FFCB941FE1A<-00007FFCB943F2CB<-00007FFCB9423CFD`

I can't tell from the chain above whether a working version has been identified. I'm sort of stuck until this is sorted out ☹️ So I will start trying different versions in the morning...