search

fralonra / wgshadertoy

A WGSL playground inspired by Shadertoy.
MIT License
91 stars 6 forks source link

Fix compiler warnings #10

Open Andrea-moth opened 7 months ago

Andrea-moth commented 7 months ago

Might need a quick review, I've added unwraps to functions that return results, but that might not be the best idea.

Other than that, should be good

fralonra commented 7 months ago

Thanks! I've done a quick review.

Apart from that, it's recommanded to use git mv to rename files rather than creating a new one then delete the old one, because it makes git to track in-file changes. You can make your changes in the orginal src/ui.rs and src/ui/highlight.rs and then git mv these files.

And better to re-organise commits (Currently there are two commits with the same description). Try git rebase -i.

BTW, are you using analyst tools other than rust-analyzer or you have a specific config? My vscode and rust-analyzer combination did not give me warnings like quotes, mut and &.