fralx / LimeReport

Report generator for Qt Framework
http://limereport.ru/
Other
403 stars 153 forks source link

Line chart: ability to set seriesLineWidth & drawPoints #348

Open 7ymekk opened 3 years ago

7ymekk commented 3 years ago

Hi @fralx,

by default line chart has lineWidth=4 & draws points, so with a lot of data (12 columns & 1800rows) it gives result as below:

image

Now, I added following properties to ChartItem:

After setting drawPoints=false & seriesLineWidth=1 I get much better, epxected result:

image

The main problem is that after adding above properties to ChartItem, they're also shown in Pie or Bar charts, which is a bit strange. I would like to make it properly but I'm afraid we would need to add separate items: PieChartItem, LineChartItem & BarChartItem.

Unless you think it's good enough to have these properties in BarChart & PieChart, then I can create pull request.

Please let me know what you think.

Thanks Jakub

fralx commented 3 years ago

Hi!

The main problem is that after adding above properties to ChartItem, they're also shown in Pie or Bar charts, which is a bit strange. I would like to make it properly but I'm afraid we would need to add separate items: PieChartItem, LineChartItem & BarChartItem.

I think that there is nothing wrong with that :) Theoretically, we can place these properties in the series and show them for the Lines series only