search

fralx / LimeReport

Report generator for Qt Framework
http://limereport.ru/
Other
403 stars 154 forks source link

LimeReport not really a reusable library #50

Open pasnox opened 8 years ago

pasnox commented 8 years ago

LimeReport is great, but the LimeReport::ReportEngine is a bit too monolithic to be reused efficiently.

In fact the PrintPreview and Designer windows are not really useful because we can not instantiate them ourselves as it's tied to the ReportEnginePrivate thing.

Please allow those dialogs to be instantiated taking a simple ReportEngine in constructor, this way we can control where and how to instantiate those to suit our needs (modal, non modal, size , screen...).

fralx commented 7 years ago

Hi ! Sorry for long waiting. Do you still need this changes ?

pasnox commented 7 years ago

Hi, no problem. We currently workaround it a bit (probably patching it), so we are not in a hurry/urgent to have this enhancement. Though having it is clearly a better thing for your library for a real custom usage.

fralx commented 7 years ago

Maybe you can send me the patch that you are using?

pasnox commented 7 years ago

Just checked our code, we directly changed some window flags at some places, no more. So this is not useful to this tasks.

fralx commented 7 years ago

Ok :) if i change ReportEnginePrivate to ReportEngine, will it enoth ?

pasnox commented 7 years ago

Yep, definitely as this is a public class :)

fralx commented 7 years ago

Could you check https://github.com/fralx/LimeReport/tree/feature/CH_Private_To_Public Is it suit you?