search

fram-x / FluidTransitions

Fluid Transitions for React Navigation
MIT License
2.93k stars 194 forks source link

Make examples Expo compatible? #62

Open slorber opened 6 years ago

slorber commented 6 years ago

Hi,

I wanted to try the examples of this lib, but unfortunately they are not published on Expo. I found some snacks but they did not work very well (mostly found in issues) so I want to see the official examples to see what can be achieved by this lib. Unfortunately this requires me to clone the repo, read the example readme etc...

Finally I was not able to run it on my phone. I think it requires react-native link in the readme for vector icons (which are actually available in Expo), and even after it didn't work with a strange error related to vector icon overriding something...

So in the end I don't know how to test this library at a glance to see if it's worth using in my apps.

I think publishing an example on Expo would help increase adoption. I am ok to submit a PR if this is approved.

chrfalch commented 6 years ago

Hi @slorber! Thanks for submitting this issue - I believe having the examples as Expo snacks would be a great idea- you are welcome to submit a PR for this!

lXSPandora commented 6 years ago

@slorber this example is with react-native-cli not with expo but works pretty well if you copy it to expo will work!!! https://github.com/lXSPandora/react-native-shared-transitions

slorber commented 6 years ago

hi,

why not embed this example in this repo's examples? I think it would be great to see many examples in a single app (like react-navigation does)

chrfalch commented 6 years ago

@slorber I have restructured files and folders to make it simpler to work with the library. Please feel free to see if the project can support Expo if you have the time!

slorber commented 6 years ago

Hi, unfortunately I don't have much time currently but I don't forget this issue

chrfalch commented 6 years ago

We'll just keep it open :-) @slorber

geminiyellow commented 6 years ago

hmm... i cloned this repo and try start example, following the readme of cause, but, 

 Requires Babel "^7.0.0-beta.41", but was loaded with "7.0.0-beta.40".
foo99 commented 5 years ago

Hi, Thank you for a wonderful library.

It is a sample running with expo. https://github.com/foo99/FluidTransitions-examples

Bye :smiley:

cek-cek commented 5 years ago

Hi! Speaking of Expo compatibility, fluid-transitions v2.6 worked with Expo Snacks flawlessly out of the box. Unfortunately, v2.7x has issues resolving some of the dependencies, such as: Device: (985:863) Unable to resolve module 'module://prop-types/checkPropTypes.js' Evaluating module://prop-types/checkPropTypes.js Evaluating module://react-navigation-fluid-transitions.js Evaluating module://App.js Loading module://App.js

Here is a sample snack containing only autoresolved dependencies in package.json. If you manually change version back to v2.6, it starts working fine.