search

framed-data / overseer

Overseer is a library for building and running data pipelines in Clojure.
Eclipse Public License 1.0
97 stars 10 forks source link

(Discussion) Suppress ineligible job exceptions #35

Closed andrewberls closed 9 years ago

andrewberls commented 9 years ago

When a worker attempts to reserve a job that's ineligible for start the reservation DB function throws an exception. This gets caught by the default exception handler, and propagated up to Sentry. This causes tons of noise in Sentry, and there's really nothing that can be done on the user's behalf in response.

This modifies the reserve-job db function to throw a specially-marked exception (with ex-info), and the default exception handler is modified to notice exceptions of this type and not propagate them through to Sentry.

This PR uses work from https://github.com/framed-data/overseer/pull/34, and is intended largely for discussion about whether or not it's the right strategy to take here.

andrewberls commented 9 years ago

The basis of this is sticking around, but the approach/merge is different enough that I'm closing this out and opening a new PR