search

framedsc / HallOfFramed

Hall-of-framed website which contains various galleries with screenshots made by the members of the community
Creative Commons Zero v1.0 Universal
6 stars 4 forks source link

add transition and about modal #13

Closed Fraulk closed 3 years ago

Fraulk commented 3 years ago

add slidIn transition for mobile menu, add about modal

i just wrote the project description in the about modal and did basic css for the modal, i'll do better css later, unless @chocmake gonna do stylish css

chocmake commented 3 years ago

Yeah, I initially tried a slide down animation using the same margin property but since I needed the mobile menu to be contained within the main header (rather than absolutely positioned) for the background blur effect to work for both elements it resulted in the menu displaying over the Framed logo/hamburger icon while it transitioned so I opted just for an opacity transition.

Ideally if the top header height (--header-height var) could be excluded during the anim using a mask or some method it'd look like it's properly sliding from underneath. Only a small detail though :)

FransBouma commented 3 years ago

@Fraulk Could you fix the merge conflicts please? They're pretty minor (just pick one of the two blocks specified) and it's easier for you to do it (as I have no idea if the changes conflict with what your changes are doing)

Fraulk commented 3 years ago

i hope i didn't break anything

and about the slide down, i think it's not looking that bad so i've kept it, but feel free to remove it

FransBouma commented 3 years ago

Deployed. Works ok! :D

FransBouma commented 3 years ago

Btw, the mobile menu doesn't contain the about modal... oversight?

Fraulk commented 3 years ago

yeah i forgot to mention but i didnt knew where to put it actually