Closed Defaltsiuncula closed 8 months ago
Hey, sup. I’ve said how I will chill for the weekend, but knowing me that’s not gonna be the case haha. I managed to compress the shots. I realized today that JPEG was the key to get the best out of the shots for the site, but also to leave them on the slider preview.
Also, I removed one imgur link, and the line which explains the result went under the shot example. It looks much better like this. Why I decided to keep small example images on imgur is only to lead a beginner who maybe never used any of these apps and he just started, so its easier for him to find what I meant. I put the .md in general guides, and images are in markdown\images. I made sure that everything is in alphabetical order as its already on site.
I mentioned about the Shadder Toggler at the beginning, because I think that’s where it makes sense the most tbh, before edits. Since I am talking about the Photoshop and Lightroom, I mentioned Deband.fx shortly at the beginning of the guide. I did some tweaks here and there.
I’m not sure about the AI if that’s gonna be complicated for someone because this guide is to solve banding fast if possible, but if you think that you can squeeze somewhere that then cool (since I’ve read this text more then 50 times, the only where I can see it is before finale, which is before grain usage on shots in general). You can add the image how grain adds details, just after I mentioned that sentence, and also please credit yourself under that shot, I would love to see that! (shot by originalnicodr) you know :)
Idk if I missed anything
Oh and I shorten from ‘’Simple Techniques to fix Color Banding, Power of Grain, Noise and Blur’’ to "Simple Techniques to fix Color Banding".
I would like to put the old title, but then it clutters the space and alphabetical order, so I think that’s too much. What you think on that. Simple thing like this can bother me a lot.
BTW I still see those docnet files, thats weird, just they are deleted. I hope thats okay!
And I also see that images are still in the same folder. Idk how, because on my PC they are in markdown\Images, not in Post-Processing.
Nvm, I realised that those are deleted images from old commit!
This is already looking much better already! Thanks for acting on the feedback!
I would still put the images files you added into its own folder inside of Images. When guides have this many images we prefer to do so because otherwise they clutter the main Images folder with a ton of files.
I am pretty busy these days, but will try to squeeze some time and include the AI model and my example (and rewrite a couple of things if you don't mind).
In the meantime if you can change the HTML tags to markdown (the ones you can at least) that would be useful. If not I will see if ai can do it myself whenever I add the things I mentioned.
Once again, thank you so much for working on this!
Awesome, glad to hear it! Images are in new folder, and I edited some HTML tags. The only thing I cannot seem to understand are the line breaks. I used HTML there. Though I can see that you guys don't use line breaks, just this ---, which I guess its cool, but I like when there is space between some parts. I tried to look somewhere else, here to be specific, but they also recommended HTML, I guess. You can tell me how to do that in Markdown and I will edit it again and push commit. I shorten the spaces a bit in couple of places.
And thank you as well for having this guide in mind. Tbh I got the idea to write this because I said to some people in 1 discord server and they fixed banding, they were so happy. And after I visited Framed couple of times from Otis server I saw the guides there, and I thought why not give it a shot and just write this. I will keep an eye on issues as well btw.
I haven't edited docnet.json, and he is not here in this latest commit. I guess I don't need to push all files every commit, or I need to do that, hmmm.
Had some time and managed to download the guide to edit it. I edited the style, added a section regarding ESGRAN models, and fixed some grammatical stuff. I ran the whole guide on Grammarly to do that last one. I recommend you do the same with future guides since it helps a ton with reaching a more publishable state.
Unfortunately, I still couldn't download the whole PR because of GitHub problems, so I will ask you to do a couple more things before merging if that's fine for you.
how-to-fix-color-banding.md
to have a short URL with mid-dashes. Also, change the name in the JSON file to match the name used in the file if possible.I ended up deciding against including my example of how grain can improve detail because it was out of the scope of what this guide covers, and it would fit better once we write a guide on grain itself.
Once again, thank you so much for the PR!
Hey, glad to hear from you! :)
Yeah I can see mistakes even though you read many times, you think something else atm and you can easily make a mistake in writing. Will keep Grammarly in mind for the future guides.
But even if you didn't download, we can edit the guide anyways in the future right, so you can edit whatever you want or me.
In terms of noise, I look at this way how in photography almost every image has a noise in it. To match original lvl of noise , added noise should not be more then lets say 2%. Because surface blur cannot fix all types of banding, adding noise back is to match the originals image lvl of noise and also to remove the banding. Also 1% is sometimes more then enough, and its not easy to spot really unlike added grain as seen in the guide unless the image is zoomed quite a bit, and it can help fixing the banding or even enhance the image further. This is the only difference really that I think of.
Its nice to talk about the grain deeply, and since you have plans to work on it, I will put the link which will lead to your guide in the future if you are ok with that instead of the image that you decided to not include.
I like how it looks now. And I can see now what you did with those tags etc. I know now for the future, thanks! And one more thing about... (I went into kitchen before typing and I forgot what I wanted to say lol, when I remember will tell you on discord)
Much Love
I've corrected a link, and changed some headers as they were really ugly.
There's no header image, and most guides have header images. It might have been better if this guide had a header image but as this PR has been open for so long we'll merge it without waiting for that.
There were several paragraphs which read more as a part of a blog post than a general guide. E.g.:
I, personally, don't apply grain when I do processing with ReShade. I like to do it after. Simply put, I want to have the cleanest image possible for various tweaks such as color adjustments, etc. that I do in Lightroom. I don't want to deal with a noisy image in post unless you are already satisfied with the shot result which has a grain on it that was applied from ReShade. A small tip anyway would be to always inspect a shot before moving on.
What you, the author, do is of little importance, more why you don't do things or do things and it might have been better if this paragraph and some others would have been written in a more general tone, so it was less of a personal post.
The main reason I bring this up is that the page is signed with your name. I started rewriting the above paragraph and realized that this would lead to a problem: your name is at the bottom but my rewritten paragraph would be written by someone else. This is a problem as our site has many contributors and pages often contain parts written by different people. Having your name at the bottom therefore will likely either result in no-one updating this guide or parts that will be rewritten by other people while your name is still at the bottom.
Hey Frans! I thought about deleting more of the text paragraphs. I also realized that some text should be more straightforward, rather than just discord talking. It's just I am like that, sometimes I write like I would talk to someone. Why is my name under some pics and at the end of the guide is only because I didn't take guide example images from elsewhere etc. so I was careful since this was my first PR ever, and first time using GitHub, and I just wanted to make things right, so people know it's from me not from somewhere else.
About others updating the guide or rewriting, I am the guy who is never happy with something, so I am not a person who will leave something after it gets released. But I completely understand, so feel free to remove it and ~rewrite it~. (will do that)
I saw how some FRAMED guides don't have a header image, so I thought this one also doesn't need it (or the idea for a header just wasn't there at first). Furthermore, I will put a header image in the future, no worries! Thanks
Hey,
saw the Framed community and its guides, after people posted couple of times the links in Otis_Inf server. I truly never saw anything like that dedicated for the screenshots as that site, so I thought it would be the best to write a guide about the usage of grain, noise and blur and how I do it to fight against color banding in different scenarios , because I think that’s what everyone encounter in general when it comes to shots.
I’ve managed to do everything alone, and I checked if everything looks right on the site. I will also update the guide if I think that I could add something, or even make a new guide to cover something else. Unrelated, but it took me around 5 days of 5-7 hours per day because I never did something like this, and it took me some time to make sure to read everything and to form the way I want to look okay on the main site. But I gotta admit, its hella fun. 😊
I’ve made a new paths. Path to shots is Images\PostProcessing, and the .md file is in new path as well, Sitesource\markdown\Post-ProcessingGuides. Everything in the guide is entirely created by me!
Much Love, SC (Defaltsiuncula)