search

framefield / tooll

Tooll is a new multi-purpose application for creating interactive 3d content and animations. It combines the best aspects of animation, compositing, and coding into a lightweight and intuitive UI. Your designs can be shared as executable or rendered to movies.
http://www.tooll.io
MIT License
638 stars 53 forks source link

public working develop branch #13

Closed necaremus closed 8 years ago

necaremus commented 8 years ago

assets-common has to be added manually, still :)

necaremus commented 8 years ago

@pixtur @drcynic split dev into dev_public and dev_private?

pixtur commented 8 years ago

True, it is super unfortunate, that the log-information is lost, but I am very hesitant to accept this request. The logger is one of the more intricate aspects of tooll, which already went through several incarnations because it...

  1. Should NEVER interfere with frame-rendering (e.g. cause frame-drops)
  2. Must work even for asynchronous messages from other threads
  3. Not cause too much performance impact when messages are written every frame.
  4. Works with console window (in Player), log-file, console-panel.

It's super cool, that you found that fix, but any of the above reasons tops the missing data in the log-file (which is admittedly also bad). So before accepting the pull-request, please make sure that you do some tests. Believe me, this construction site might be a bit more complex than you might think.

pixtur commented 8 years ago

Hi @necaremus, Thanks for the pull-request. Is there a way to split these requests more granularity? I would accept the file-logger auto-flush and the the build-file fixes individually.

necaremus commented 8 years ago

huhu @pixtur uhm... maybe create a dev_public branch where i can upload the build-file fixes too? or is the current develop branch public and you got a private non visible? :3

and i actually thought the logger would be a 2nd pull-request, but github automaticly chained it :D i, right now, would not know how to split it into 2 pull request, unless there are 2 different branches ... or submit one pull-request, wait for accept, than the 2nd (but i am super new to github!) so far, neeca

necaremus commented 8 years ago

@pixtur did a quick google-search

those two seem to be the only options >_> /edit: zzz should read more than the top rated post

necaremus commented 8 years ago

i think i need 2 close dis