Closed anark closed 2 years ago
Can we get this merged? Related to #1509
Ship it! 🚢
LGTM. Let's get this fix out 🚀
You should also add it to the <LayoutGroup />
component IMO, I've searched accross the codebase, and these are the two components (<AnimatePresence/>
and <LayoutGroup />
) that should be affected by the changes of the types
Thanks @Liinkiing , I've added that type change as well
Hi @anark ,
When do you plan a release with this fix ?
Kind regards,
Hi @anark ,
When do you plan a release with this fix ?
Kind regards,
I'm not an admin of this repo. It is up to them if/when the accept this fix and release
@mattgperry could you please review this. It's a major blocker for me and several others. Thanks.
@mattgperry could you please review this. It's a major blocker for me and several others. Thanks.
In the meantime, you could add a @ts-expect-error
, it should be non blocking as it is just a TS issue, and you don't have to patch the package, so the ts-expect-error
should to the trick
Great PR, thanks for jumping in!
Also facing this issue with the AnimateSharedLayout
Component
@sachaw AnimateSharedLayout has been deprecated since 5 https://www.framer.com/docs/guide-upgrade/#%23shared-layout-animations
After upgrading my React app to version 18 and upgrading
@types/react
to v18 I was getting errors when using theAnimatePresence
componentThis should fix the issue.