framesjs / frames.js

The fastest way to make Frames
https://framesjs.org
MIT License
355 stars 100 forks source link

Debugger android deep link issue #150

Closed julien51 closed 5 months ago

julien51 commented 8 months ago

when using the debugger, I am scaning the QR code from my phone but on my android phone, this opens a Google saerch... (deep link issue?) Similarly, when clicking on the openurl button on my Mac, it does not seem to go anywhere

Screenshot 2024-03-06 at 3 16 13 PM

Yuripetusko commented 6 months ago

Same issue here. the qr code gives me deeplink url like farcaster://... I think it's wrong, at least for the android, and I was able to replace it with https://client.warpcast.com/deeplinks/signed-key-request?token=FOO, which takes me to @mod approval in warpcast client, but then it fails with InvalidMetadata

Yuripetusko commented 6 months ago

Ok just managed to try it on ios and got the same error InvalidMetadata 🤔

stephancill commented 6 months ago

@Yuripetusko assuming this is on the hosted debugger at https://debugger.framesjs.org, would you mind trying to clear your localstorage using localStorage.clear() in the browser console when on there and trying again? InvalidMetadata sounds like an expired signature

Yuripetusko commented 6 months ago

Ok after many failed attempts I finally managed to make it work.

  1. I had incorrect evn var set. FARCASTER_DEVELOPER_ID instead of FARCASTER_DEVELOPER_FID
  2. Once I verified that all envs are passed to frames debugger correctly, I copied the generated sign in link token
  3. Then posted a link in a chat/messanger to myself so I could click it on android https://client.warpcast.com/deeplinks/signed-key-request?token=${token}
  4. Clicked the link on android, this deeplinks to Warpcast. If this worked correctly it shows 2 of your avatars (big one, and then a signed smaller avatar circle), instead of @mod avatar and your avatar
  5. Signed, and success
stephancill commented 6 months ago

Thank you for reporting this, will look into adjusting the returned deeplink url to improve the UX for android users

stephancill commented 5 months ago

This issue should be resolved in the next release