framesurge / perseus

A state-driven web development framework for Rust with full support for server-side rendering and static generation.
https://framesurge.sh/perseus/en-US
MIT License
2.18k stars 89 forks source link

perseus-cli/0.4.2 crate is missing the tests folder #305

Closed srid closed 10 months ago

srid commented 1 year ago

https://crates.io/crates/perseus-cli/0.4.2 does not have https://github.com/framesurge/perseus/tree/main/packages/perseus-cli/tests

Trying to build this in Nix,

error: builder for '/nix/store/3v37xknb9ij2hsvazh4g0bqjscp2j3gi-perseus-cli-0.4.2.drv' failed with exit code 101;
       last 10 log lines:
       >    Compiling assert_fs v1.0.12
       >    Compiling perseus-cli v0.4.2 (/private/tmp/nix-build-perseus-cli-0.4.2.drv-0/perseus-cli-0.4.2.tar.gz)
       >    Compiling webpki v0.22.0
       >    Compiling sct v0.7.0
       >    Compiling webpki-roots v0.22.6
       >    Compiling ureq v2.6.2
       > error: couldn't read tests/lib.rs: No such file or directory (os error 2)
       >
       > error: could not compile `perseus-cli` (test "integration") due to previous error
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run 'nix log /nix/store/3v37xknb9ij2hsvazh4g0bqjscp2j3gi-perseus-cli-0.4.2.drv'.

The crate is missing the tests/ folder:

image
github-actions[bot] commented 1 year ago

This repo is set up to triage issues with Tribble, but this issue couldn't be processed. If you deliberately didn't use Tribble to report this issue, you can safely ignore this warning. If you did, something's gone wrong here.

arctic-hen7 commented 1 year ago

Hey there, so sorry for the late reply on this, I've been really busy lately, but I am back! The reason for this is because the Perseus CLI tests are very heavy. I strongly recommend against running them locally, they take about half an hour on CI because they involve end-to-end testing of the entire build process. We make sure that everything passes before releasing, and you could check against GitHub Actions' records for this maybe? I'm not very familiar with Nix though, but I'm happy to help resolve this if you give me some more info about why it's required to run those particular tests.

arctic-hen7 commented 10 months ago

@srid I'm closing this due to inactivity for now, but please let me know if it's still an issue for you.