framework7io / framework7-vue

Deprecated! Build full featured iOS & Android apps using Framework7 & Vue
http://framework7.io/vue/
MIT License
674 stars 150 forks source link

ie 11 does not work, because it does not support Object.assign #129

Closed akralj closed 7 years ago

akralj commented 7 years ago

Hi, Object.assign is used there in 4 places (see this link))

Using this polyfill fixed it for me: https://github.com/rubennorte/es6-object-assign It would be great to add this to framework7-vue to make ie 11 happy.

bencompton commented 7 years ago

Hey, nice job getting it working in IE. I think adding a polyfill in your own project is a perfectly reasonable solution. I can't imagine that a lot of people are using F7 with IE (but who knows, I may be surprised), so I'm not sure it is worth adding the polyfill as a dependency to F7 Vue. It is nice how F7 Vue is so compact with no dependencies right now.

konstantin-popov commented 7 years ago

Actually, this problem also applies to Android at least up to and including 5.1 (see http://kangax.github.io/compat-table/es6/).

bencompton commented 7 years ago

@konstantin-popov, good point. I suppose the appropriate Babel transform could be added then.

konstantin-popov commented 7 years ago

@bencompton, looks like a good solution too. I understand you don't want to add extra dependencies and it could easily be done on app level, but may be this should be added into the docs? AFAIK Framework7 itself supports Android 4.4+, Vue.js supports Android Browser 4.2+, so if Framework7-vue has other environment requirements it should be mentioned somewhere, possibly with a brief description of possible workarounds.

scriptPilot commented 7 years ago

Instead of creating a dependency, is there any point against the proposition just to add the code from the polyfill directly to F7Vue ?

mix3d commented 7 years ago

Why was this closed?

Is there a preferred way to run the polyfill on the f7-vue module through webpack/babel?