search

framework7io / framework7

Full featured HTML framework for building iOS & Android apps
http://framework7.io
MIT License
18.06k stars 3.23k forks source link

[Intervention] error in console on 'touchmove' - Color Picker #3922

Open MDB80 opened 3 years ago

MDB80 commented 3 years ago

Framework7 version: 6.0.22 Platform and Target:Cordova app + Chrome browser

Describe the bug

An error occurred when swipe a Color Picker

[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

To Reproduce

Steps to reproduce the behavior: Create a Color Picker and swipe

Screenshots

Schermata 2021-07-19 alle 15 09 27

Additional context

To solve the problem please change " e.preventDefault(); " with: if (e.cancelable) { e.preventDefault(); } at line 106 of the "color-picker/modules/wheel.js" file

DAnn2012 commented 3 years ago

Hello @MDB80

Please, You could check if this change is also required to these other Color Picker modules?

https://github.com/framework7io/framework7/blob/52b7e116e41cefab06e5f34e6dec139222426716/src/core/components/color-picker/modules/hs-spectrum.js#L67

https://github.com/framework7io/framework7/blob/52b7e116e41cefab06e5f34e6dec139222426716/src/core/components/color-picker/modules/sb-spectrum.js#L66

Do you think this change is needed even in other f7 components?

Thanks.

MDB80 commented 3 years ago

Hello, yes.....and also, in “framework7/src/core/components/range/range-class.js” at line 287.

framework7-bundle.js:47656 [Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

framework7-bundle.js:24975 [Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

framework7-bundle.js:47534 [Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

Best regards,

Max

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

DAnn2012 commented 2 years ago

Hello @MDB80

Considering that the source code of the current 7.0.1 version is identical to the one above, could you please kindly check if the problem still occurs?

https://github.com/framework7io/framework7/blob/c6bc8338ba47941d9ba5255c1f7b02c239241de3/src/core/components/color-picker/modules/wheel.js#L106

https://github.com/framework7io/framework7/blob/c6bc8338ba47941d9ba5255c1f7b02c239241de3/src/core/components/color-picker/modules/hs-spectrum.js#L67

https://github.com/framework7io/framework7/blob/c6bc8338ba47941d9ba5255c1f7b02c239241de3/src/core/components/color-picker/modules/sb-spectrum.js#L66

https://github.com/framework7io/framework7/blob/c6bc8338ba47941d9ba5255c1f7b02c239241de3/src/core/components/range/range-class.js#L287

Thanks.