framework7io / framework7

Full featured HTML framework for building iOS & Android apps
http://framework7.io
MIT License
18.13k stars 3.23k forks source link

Action Sheets longer than a screen no longer scroll #4074

Open jimbergman opened 2 years ago

jimbergman commented 2 years ago

Describe the bug

Long Action Sheets won't scroll.

Also when the app is installed on a device, if you tap-hold and move you finger to either side of the screen, you get this error:

Uncaught TypeError: Cannot read property 'closest' of null at Framework7.handleTouchMove (framework7.bundle.js:4376) at framework7.bundle.js:2573 at Array.forEach (<anonymous>) at framework7.bundle.js:2572 at Array.forEach (<anonymous>) at Framework7.emit (framework7.bundle.js:2566) at emitAppTouchEvent (framework7.bundle.js:4483) at HTMLDocument.appTouchMoveActive (framework7.bundle.js:4498)

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://jsfiddle.net/s6750g1a/
  2. Click on 'TEST' button
  3. Tap-hold and try to scroll the list.
  4. See behavior described.

Expected behavior

A long Action Sheet should be scrolled by tap-hold and slide up and down. This used to work in older Framework7 versions.

Actual Behavior

The Action Sheet won't scroll and selects whichever Action Sheet item is under your finger when you lift it up.

Screenshots

n/a

Additional context

works fine in F7 v6x, first noticed in F7 v7.0.5 and still doesn't work in v7.0.8