framework7io / framework7

Full featured HTML framework for building iOS & Android apps
http://framework7.io
MIT License
18.06k stars 3.23k forks source link

fix(core): Improve router back with history condition #4077

Closed Simone4e closed 1 year ago

Simone4e commented 1 year ago

The router.back () does not take into account the history: false, keeping the old page in the DOM, adding theoptions.history condition in the navigate.js file in the keepOldPage variable should solve the problem.

Issue page: Link Actually code:

let keepOldPage =
      (router.params.preloadPreviousPage || router.params[`${app.theme}SwipeBack`]) && !isMaster;

Fix code:

let keepOldPage =
      (router.params.preloadPreviousPage || router.params[`${app.theme}SwipeBack`]) && !isMaster && options.history;
peitschie commented 1 year ago

The fix seems to be missing from here by the way @Simone4e ... looks like this is just trying to merge v8 into master 🙂

Simone4e commented 1 year ago

@peitschie seems like I wrong something 😅, can you open the issue for merge with framework? I will close that