search

framework7io / framework7

Full featured HTML framework for building iOS & Android apps
http://framework7.io
MIT License
18.06k stars 3.23k forks source link

Theme Color Issue with Dialogbuttons? #4104

Closed phoebusryan closed 1 year ago

phoebusryan commented 1 year ago

Describe the bug

If I change the theme-color of F7 via Bodyclass to e.g. Purple (color-theme-deeppurple), the dialogbuttons are still blue. I think, that's not correct.

To Reproduce

Set theme to e.g. purple. The color-Attribut in CSS-Class ".dialog-button" uses the variable "--f7-dialog-button-text-color)" which is always blue. I know I can change this by myself but isn't it wrong that the button isn't purple?

Expected behavior

Dialog-Buttons should also be purple.

Actual Behavior

Dialog-Buttons are blue.

Simone4e commented 1 year ago

Live Link or CodeSandbox: please add it.

phoebusryan commented 1 year ago

Sorry for my late response.

Just go to https://framework7.io/docs/dialog#examples

... and changed the theme to a different color via Firebug or similar (direct or via javascript with this command: Dom7('.view-main').addClass('color-theme-red');

.... then click on "ALERT" or any other buttons to see that the buttons still have blue color.

nolimits4web commented 1 year ago

Dialog is rendered our of the View, you need to add class to body/html or to dialog itself

phoebusryan commented 1 year ago

Okay, makes sense. How can I add a class to the dialog?