Unable to navigate back a second time with async route when on same page - Githubissues

framework7io / framework7

Full featured HTML framework for building iOS & Android apps

http://framework7.io

MIT License

18.06k stars 3.23k forks source link

Unable to navigate back a second time with async route when on same page #4111

Closed peitschie closed 1 year ago

peitschie commented 1 year ago

Framework7 version: [e.g. 3.0.0]
Platform and Target: [e.g. iOS 11 Cordova app, or Android 8 Chrome browser]
Live Link or CodeSandbox: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP). You can start from forking the following CodeSandbox template: CodeSandbox

Describe the bug

Navigating back to current URL a second time with an async route leaves allowPageChange incorrectly set to false after routing has completed.

Related to #2200. The fix for #2200 in https://github.com/framework7io/framework7/commit/83abadd66d0d003fdcaf0857d70f37ee8d9e6447 only addresses navigate, and missed applying the same fix on back

To Reproduce

Reproduction app at https://codesandbox.io/p/sandbox/eager-kepler-ozg9yr

Steps to reproduce the behavior:

Starting on an async route
Navigate forward ("Click me first" in sandbox)
After arriving at the second page, navigate back to the original url exactly ("Demonstrate bug" in sandbox)
Once arriving back on the original route, try and navigate back to the same url again (it MUST be an async route to show the defect)
Observe that now allowPageChange remains false

Expected behavior

At step 5, allowPageChange should return to true once the back command completes without updating the page.

Actual Behavior

At step 5, allowPageChange incorrectly remains false once the back command completes without updating the page.