framework7io / framework7

Full featured HTML framework for building iOS & Android apps
http://framework7.io
MIT License
18.04k stars 3.23k forks source link

fix(panel): fix panel close routine if it was closed immediately #4127

Closed peitschie closed 1 year ago

peitschie commented 1 year ago

fixes #4108 (again)

In practice, the time until the transition start is variable depending on the browser, amongst other things. Android + Chrome is between 27 => 44ms with a fast phone, but can take longer under many circumstances.

This removes the hardcoded time and instead looks for the transition start.

Depends on the new transitionStart method added to Dom7 in https://github.com/nolimits4web/dom7/pull/62

peitschie commented 1 year ago

Thanks for the quick review and merge @nolimits4web

Just wanted to note, the Dom7 library in Framework7 core will need to be bumped to the new 4.0.5 release to ensure the new method is available 😅

nolimits4web commented 1 year ago

Yes, it should be there in F7 7.1.4