search

framework7io / framework7

Full featured HTML framework for building iOS & Android apps
http://framework7.io
MIT License
17.97k stars 3.24k forks source link

Core modal. Sometimes parameters are disposed due to the rase condition. #4270

Open ievgennaida opened 2 months ago

ievgennaida commented 2 months ago 
  "dependencies": {
    "framework7": "^8.3.0",
    "framework7-svelte": "^8.3.0",
    "svelte": "^4.2.0"
  },
  "devDependencies": {
    "@sveltejs/vite-plugin-svelte": "^2.4.5",
    "vite": "^4.4.9"
  }

Describe the bug

When modal is disposed some events still can be fired that can lead to undefined access exception. (See screenshot)

To Reproduce

It's hard to reproduce issue while happening in rare cases due to some rase. but sometimes when modal is disposed parameres are empty and line displayed in the screenshot is crashing app.

Expected behavior

Just check that parameters are not undefined before using them.

Actual Behavior

Exception.

Screenshots

Lines 55 and 60 image