search

fran6co / homebrew-cv

Computer vision formulas
17 stars 9 forks source link

FindGLEW.cmake patch fails. #10

Closed MartinHjelm closed 10 years ago

MartinHjelm commented 10 years ago

Got this when trying to reinstall PCL using your formula:

brew install -vd fran6co/cv/pcl --with-openni --with-qt --HEAD /usr/local/Library/brew.rb (Formulary::FromPathLoader): loading /usr/local/Library/Taps/fran6co-cv/pcl.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/cmake.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/pkg-config.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/boost.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/eigen.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/flann.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/hdf5.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/szip.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/cminpack.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/qhull2011.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/libusb.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/autoconf.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/automake.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/libtool.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/glew.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/qt.rb /usr/local/Library/brew.rb (Formulary::FromPathLoader): loading /usr/local/Library/Taps/homebrew-versions/vtk5.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/sip.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/pyqt.rb /usr/local/Library/brew.rb (Formulary::FromPathLoader): loading /usr/local/Library/Taps/homebrew-science/openni.rb /usr/local/Library/brew.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/doxygen.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/boost.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/eigen.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/flann.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/hdf5.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/szip.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/cminpack.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/qhull2011.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/libusb.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/glew.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/qt.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::FromPathLoader): loading /usr/local/Library/Taps/homebrew-versions/vtk5.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::FromPathLoader): loading /usr/local/Library/Taps/homebrew-science/openni.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/cmake.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/pkg-config.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/autoconf.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/automake.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/libtool.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/doxygen.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/git.rb /usr/local/Library/Taps/fran6co-cv/pcl.rb (Formulary::StandardLoader): loading /usr/local/Library/Formula/python.rb ==> Cloning https://github.com/PointCloudLibrary/pcl.git git --git-dir /Library/Caches/Homebrew/pcl--git/.git status -s Updating /Library/Caches/Homebrew/pcl--git git config remote.origin.url https://github.com/PointCloudLibrary/pcl.git git config remote.origin.fetch +refs/heads/master:refs/remotes/origin/master git fetch origin git checkout -f master Already on 'master' Your branch is up-to-date with 'origin/master'. git reset --hard origin/HEAD HEAD is now at 9e1e7f3 Merge pull request #533 from chambbj/morphological-filters-new git reset --hard origin/HEAD HEAD is now at 9e1e7f3 Merge pull request #533 from chambbj/morphological-filters-new git checkout-index -a -f --prefix=/private/tmp/pcl-d6Fj/ ==> Patching patching file cmake/Modules/FindQhull.cmake Hunk #1 succeeded at 47 with fuzz 1. patching file cmake/Modules/FindGLEW.cmake Hunk #1 FAILED at 46. 1 out of 1 hunk FAILED -- saving rejects to file cmake/Modules/FindGLEW.cmake.rej Error: Applying DATA patch failed /usr/local/Library/Homebrew/patch.rb:74:in apply' /usr/local/Library/Homebrew/options.rb:19:into_proc' /usr/local/Library/Homebrew/formula.rb:638:in each' /usr/local/Library/Homebrew/formula.rb:638:inpatch' /usr/local/Library/Homebrew/formula.rb:270:in brew' /usr/local/Library/Homebrew/formula.rb:624:instage' /usr/local/Library/Homebrew/resource.rb:62:in unpack' /usr/local/Library/Homebrew/extend/fileutils.rb:21:inmktemp' /usr/local/Library/Homebrew/resource.rb:59:in unpack' /usr/local/Library/Homebrew/resource.rb:52:instage' /usr/local/Library/Homebrew/formula.rb:622:in stage' /usr/local/Library/Homebrew/formula.rb:268:inbrew' /usr/local/Library/Homebrew/build.rb:151:in install' /usr/local/Library/Homebrew/build.rb:45:inmain' /usr/local/Library/Homebrew/build.rb:12 /usr/local/Library/Taps/fran6co-cv/pcl.rb:62

fran6co commented 10 years ago

Thanks for the bug report!

Fixed!

shanedgriffith commented 10 years ago

I just downloaded the vtk6-fixes and got the same error as MartinHjelm.

fran6co commented 10 years ago

Don't use vtk6-fixes, it's not stable and doesn't have all the latest changes. If you really want to use it you should modify the homebrew formula and add where it says:

# fixes GLEW linking and qhull2011
    [DATA] + fixes

you can add

fixes += ["https://github.com/PointCloudLibrary/pcl/pull/363.patch"]

# fixes GLEW linking and qhull2011
    [DATA] + fixes

and test it. Not sure if it's going to merge cleanly though.

shanedgriffith commented 10 years ago

Thanks. I just installed the head version without that patch and everything worked.