search

fran6co / homebrew-cv

Computer vision formulas
17 stars 9 forks source link

OpenNI2 support and Mavericks HEAD requirement fix #14

Closed pammacdotnet closed 10 years ago

pammacdotnet commented 10 years ago

Dear @fran6co, I've add a simple modification to your formula that enables the use of an experimental (though stable enough) PCL repo with OpenNI v2 support. This repo is currently pull-requested and until the PCL project accepts it, it'd be nice to be able to use with the appropriate formula optional parameters. I've tested it with my own ASUS Xtion Pro Live and works like charm.

I've also modified the Marvericks/HEAD warning message because the warning did not happen until the install phase. It now warns the user before any action (patch, install) takes place and stops formula install if --HEAD is not specified on Mavericks and/or with OpenNI2.

Hope you find my contributions useful, thanks a lot.

fran6co commented 10 years ago

@pammacdotnet I made my own version of your PR, I prefer to merge the openni2 patch than using your repository. This way it should get the latest version of PCL without having to rebase your repo.

pammacdotnet commented 10 years ago

It's OK @fran6co ... it's your formula (which I'm very thankful for) and I respect your point of view, but OpenNI v2 won't work with PCL official repo until they decide to merge the "openni2_pullrequest" pcl branch from @kwaegel. This can take from days to months... and until then, it's a nice solution that let's us to play with OpenNI2 devices with a simple brew parameter.

fran6co commented 10 years ago

@pammacdotnet, sorry I didn't link the actual commit I juste made => 036dc87b56871018a521d54a4c35c3527474213c

Should get your Pullrequest and merge it to the code in the formula. I think that is a cleaner way to do the same.

fran6co commented 10 years ago

Give it a try and let me know if everything works all right, I don't have the time to test it now.

pammacdotnet commented 10 years ago

Flawless...worked perfectly... Thanks a lot!

kwaegel commented 10 years ago

Just as a heads up, my OpenNI2 pull request occasionally breaks due to upstream changes in PCL. This is almost always due to minor conflicts in io/CMakeLists.txt. I usually go back in and fix this with a rebase, but it's likely to keep happening until that file is merged into PCL trunk.

Feel free to submit Mac bug reports and patches. :)