search

franMarz / TexTools-Blender

TexTools is a UV and Texture toolset created several years ago for Blender and Max by @renderhjs. In this open repository, originally created by @SavMartin, we develop the current version of this popular Blender add-on.
Other
1.99k stars 135 forks source link

Organize is broken but I think I fixed it here #9

Closed CAPA14 closed 4 years ago

CAPA14 commented 4 years ago

When trying to press "Organize" an error pops up in line 100 of op_bake_organize_name.py

This line: 100 obj_B.name = utilities_bake.get_bake_name(obj_A)+" high"

The error complains about "utilities_bake.get_bake_name" which doesn't exist.

Digging a bit found the utilities_bake.py and indeed it doesn't exist or anywhere else in all files of te addon.

Not sure if it's the right thing to do but, I changed get_bake_name to get_set_name instead. Then it worked to renaming the stuff and matching the HP to LP names.

This is broken in 1.3 version for 2.79 and 2.8

AvisParadocs commented 4 years ago

Thanks! That actually fixes an issue. Now organize is working for me too. Maybe you should make a pull request.

CAPA14 commented 4 years ago

Good to know! @AvisParadocs

How should I do this? I need to Fork commit to it and Request Pull from there?

AvisParadocs commented 4 years ago

I believe so.

schroef commented 4 years ago

You did not make a pull request yet correct?

CAPA14 commented 4 years ago

Nope. I did not requested the pull.

Actually made my fork and branch, tested some stuff and forgot :D

Em 23/11/2019 15:17, schroef escreveu:

You did not make a pull request yet correct?

-- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or unsubscribe [2].

Links:

[1] https://github.com/SavMartin/TexTools-Blender/issues/9?email_source=notifications&email_token=AGCZISIO43F4BYER5TNKW73QVFXUZA5CNFSM4JE6LZM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE72W6A#issuecomment-557820792 [2] https://github.com/notifications/unsubscribe-auth/AGCZISL735FKE6URBNG4R63QVFXUZANCNFSM4JE6LZMQ

SavMartin commented 4 years ago

@CAPA14 Thx for your help to fix this issue, I fix the line.