francescmm / GitQlient

GitQlient: Multi-platform Git client written with Qt.
https://www.francescmm.com
GNU Lesser General Public License v2.1
843 stars 84 forks source link

GitQlient.pro: Improve distro packagability #266

Closed hartwork closed 1 year ago

hartwork commented 1 year ago

Description

Three small related things for GitQlient.pro:

CC @band-a-prend

Change Type

Reason

Distro packaging is based on source tarballs and they do not come with a .git folder, so packaging currently has to patch away invocation of Git, e.g. see https://github.com/gentoo/guru/blob/0c250f9633324eb35160cb1906087e386f3e6411/dev-vcs/gitqlient/gitqlient-1.6.1.ebuild#L35-L36

Related Issue

n/a

Tests

Add debug output and play with the two main cases:

# qmake5 GitQlient.pro
[..]
Project MESSAGE: Found version "1.6.1" at commit "e604c6eb".

# qmake5 GitQlient.pro VERSION=1.2.3 GQ_SHA=4567
[..]
Project MESSAGE: Found version "1.2.3" at commit "4567".
francescmm commented 1 year ago

Oh yeah! I like it @hartwork!

Thanks for making it easier for other distros to have it. Packaging is way out of my area so all the help I can get with that is more than welcome.

hartwork commented 1 year ago

@francescmm cool! Ready to merge?

francescmm commented 1 year ago

Ready! Yesterday I had to leave :D

hartwork commented 1 year ago

@francescmm with these changes merged now, any chance for a release 1.6.2?

francescmm commented 1 year ago

Let me check the stability since I added some minor improvements/features! But I'll get back to you soon!

hartwork commented 1 year ago

@francescmm sounds great, thank you! :+1: