francescmm / GitQlient

GitQlient: Multi-platform Git client written with Qt.
https://www.francescmm.com
GNU Lesser General Public License v2.1
843 stars 84 forks source link

QMake: Detect and report missing Git submodules #269

Closed hartwork closed 1 year ago

hartwork commented 1 year ago

Description

It's too easy to run into compile errors from a Git clone, and it would be nice to provide help to users that prevents that situation and explains what to do instead.

Change Type

Reason

This will stop QMake from creating a Makefile and will hence stop users from running into compile errors from missing Git submodules, i.e. issue #268.

Related Issue

268

Tests

Delete all Git submodules, run QMake, compare expected output, check fro non-zero return code and lack of Makefile, then bring back Git submodules, and run QMake again, no error and Makefile present