search

francescmm / GitQlient

GitQlient: Multi-platform Git client written with Qt.
https://www.francescmm.com
GNU Lesser General Public License v2.1
843 stars 84 forks source link

Fix RepoConfig and Settings tabs GUI Styles colors #273

Closed band-a-prend closed 1 year ago

band-a-prend commented 1 year ago

Description

This pull request fixes styles issue for dark and bright theme:

Change Type

Reason

The some Styles elements aren't populated in KDE Plasma environment both for dark and bright theme

Related Issue

https://github.com/francescmm/GitQlient/issues/262

Tests

  1. RepoConfig Dialog window

before patch bright_RepoConfig dark_RepoConfig

after patch bright_RepoConfig_patched dark_RepoConfig_patched

  1. GitQlient settings tab (dark theme) : QComboBox

before patch dark_settings_GitQlient_tab

after patch dark_settings_GitQlient_tab_patched

  1. GitQlient settings tab (bright theme) : QComboBox

before patch bright_settings_GitQlient_tab

after patch bright_settings_GitQlient_tab_patched

  1. Repository settings tab (dark theme) : QComboBox, CheckBox (font color)

before patch dark_settings_Repository_tab

after patch dark_settings_Repository_tab_patched

  1. Repository settings tab (brigth) : QComboBox, QGroupBox

before patch bright_settings_Repository_tab

after patch bright_settings_Repository_tab_patched

  1. Plugins settings tab (dark theme) : QGroupBox

before patch dark_settings_Plugins_tab

after patch dark_settings_Plugins_tab_patched

  1. Shortcuts settings tab (dark theme) : QGroupBox

before patch dark_settings_Shortcuts_tab

after patch dark_settings_Shortcuts_tab_patched

francescmm commented 1 year ago

OMG @band-a-prend, thank you so much! :smile:

band-a-prend commented 1 year ago

I didn't have time to check how it looks e.g. in Ubuntu (on virtualbox) without KDE Plasma. But I hope that changes don't brake styles in other DE.

francescmm commented 1 year ago

Locally in my Ubuntu machine I cannot see any issue, so I'll probably merge it soon :)