francescorandi / optics

GNU General Public License v3.0
2 stars 0 forks source link

Plotting of models #42

Open ivergara opened 8 years ago

ivergara commented 8 years ago

OpticalModel has a method to plot itself, but you created a method in OpticalSystem that does somewhat the same.

This is, first a very inefficient thing to do. Second, it seems wierd to me. You ask OpticalSystem to plot an OpticalModel by giving him an instance of OpticalModel instead of just picking such an instance and asking it to plot itself.

Unless you see somethign I don't see I suggest to remove the plotModel method in OpticalSystem