search

francescotescari / XiaoMiToolV2

XiaomiTool V2 - Modding tool for xiaomi devices
https://www.xiaomitool.com
Apache License 2.0
627 stars 123 forks source link

Separate branches for platforms is bad idea #63

Open davispuh opened 2 years ago

davispuh commented 2 years ago

Separate branches for platforms is bad idea.

Currently if something gets fixed and merged into master, other branches will stay broken for other platforms.

A lot better way would be a folder for platform specific tools like: tools/windows, tools/linux and such. That way would have single codebase that would handle all platforms.

This can be implemented in 2 ways:

  1. when building based on target it would copy platform binaries to required folder.
  2. choose which folder to use in runtime based on current platform, no need to replace in build step