franciscoBSalgueiro / en-croissant

The Ultimate Chess Toolkit
https://encroissant.org
GNU General Public License v3.0
540 stars 64 forks source link

Add the possibility to train from a PGN #200

Closed Cassandre60 closed 6 months ago

Cassandre60 commented 6 months ago

Describe the feature

Like in a Lichess study, in Chessable or in Chess Tempo, having the possibility to play very line stored in a PGN is an extremely important feature for all chess levels. A basic version of simply getting to play a random line at a time of out the file would be a great first step.

franciscoBSalgueiro commented 6 months ago

This already exists.

https://encroissant.org/docs/guides/manage-repertoire#practice-mode

Cassandre60 commented 6 months ago

The already implemented practice feature is somewhat different from the ones available in the sites I mentioned above. First, I can't directly import a PGN and directly start "practice" on it right away (I need to create a repertoire first). Secondly, in these other sites, you just play one color and the game automatically chooses a response while in en croissant you have to click practice next position every time which is very impractical. There is also the problem of forcing me to fill the file "by hand" in the repertoire, while I want mostly to use my already constructed file.

Some of these might not be a real issue and just my ignorance about en croissant since I am a new user, but making these tasks as simple and intuitive as possible will probably help new users like me navigate the program better.

franciscoBSalgueiro commented 6 months ago

Can you explain what you mean by filling the file "by hand"? An already constructed file can be used as a repertoire, either by copying it to the files folder, or copy-pasting the contents to the PGN input in a new file.

Automatically going to the next position when you get it right is a good idea.

Cassandre60 commented 6 months ago

Thanks for the quick reply, As you mentioned it works by moving my PGN to ...\Documents\EnCroissant on Windows, that solves the "by hand" comment. Still, would it be possible to make it so that I can get a practice by going directly through the main menu with Board > Import Game instead of File>create repertoire.

I have some other niche complaints/feature requests, but you tell me if I'm being annoying to you or if this is even the correct way/channel to post them.

franciscoBSalgueiro commented 6 months ago

Not at all, feel free to open more issues!

I've just added that extra option directly in the Import Game (https://github.com/franciscoBSalgueiro/en-croissant/commit/c31b23c632e60e1782752c44c79bca0eb2f187bd)

Cassandre60 commented 6 months ago

Thanks.