search

franciscoBSalgueiro / en-croissant

The Ultimate Chess Toolkit
https://encroissant.org
GNU General Public License v3.0
625 stars 77 forks source link

live analysis prematurely marking a game as a threefold repetition draw #288

Open gahtan-syarif opened 6 months ago

gahtan-syarif commented 6 months ago

Describe the bug

this exists in the latest stable version. i noticed that the threefold detection in en croissant is wrong, for example in this pgn below if you make the move Ba5 on move 153 then en-croissant would mark it as threefold repetition draw when it isnt. pgn.txt

Reproduction

load the pgn i gave up to move 152 ply 2, and then make the move Ba5.

Platform and versions

windows 11 using latest en croissant release

Stack trace

No response

Cankyre commented 6 months ago

Would you be able to recreate the issue with a shorter game ?

gahtan-syarif commented 6 months ago

Would you be able to recreate the issue with a shorter game ?

not sure, the game that i gave was one that i found accidentally

franciscoBSalgueiro commented 5 months ago

I've checked and it's not because of three fold repetition, it's because of the 50 move rule, as the last pawn move was 84. d4.

gahtan-syarif commented 5 months ago

I've checked and it's not because of three fold repetition, it's because of the 50 move rule, as the last pawn move was 84. d4.

no, the last pawn move was 115. g5 you can check the half move clock counter for the move where it is adjucdicated as a draw, its still 76