Engines don't load or update correctly

pbennyjoseph commented 4 months ago

Describe the bug

What

I had a stockfish and komodo downloaded
I tried to remove stockfish and nothing happened
On the next launch, there was no stockfish so I clicked on download.
Now I'm pretty sure the download didn't finish as the internet was slow, and I closed the app
Now when I import a PGN and click on analysis tab, I get this error down below

What is expected

I expect to see either the engine installed and working or no engine at all.

Image showing error when going to analysis tab in en-croissant

Reproduction

Download latest version
Try removing stockfish as the engine (once you have it installed)
Now throttle your internet and download stockfish again.
Now you cannot stop the download or pause it so close the app
Reopen the app and load a pgn and go to analysis tab to see it being broken

Platform and versions

app version: v0.10.0 Mac OS (Sonoma 14.4.1) on M1 Pro

Stack trace

[@mantine/core] Duplicate options are not supported. Option with value "Stockfish" was provided more than once
fle@tauri://localhost/assets/index.js:83:140346
hle@tauri://localhost/assets/index.js:83:141500
PI@tauri://localhost/assets/index.js:38:19577
boe@tauri://localhost/assets/index.js:40:44193
goe@tauri://localhost/assets/index.js:40:39897
W9e@tauri://localhost/assets/index.js:40:39820
Cy@tauri://localhost/assets/index.js:40:39669
$O@tauri://localhost/assets/index.js:40:36024
aW@tauri://localhost/assets/index.js:40:36829
Z1@tauri://localhost/assets/index.js:38:3293
@tauri://localhost/assets/index.js:40:34341

pbennyjoseph commented 4 months ago

I'd love to contribute to this and code the fix myself but I've never heard of tauri before so I'm not sure

pbennyjoseph commented 4 months ago

I've narrowed down the problem to this page where I think the "keys" to each engine or unique_id is the Name which might not be accurate. Renaming the engine names or removing them here works fine.

Selyss commented 4 months ago

I've narrowed down the problem to this page where I think the "keys" to each engine or unique_id is the Name which might not be accurate. Renaming the engine names or removing them here works fine.

I had this issue with duplicate file paths (using the same path for a lc0 binary for multiple engine profiles).

guyru commented 4 months ago

I had the same as @Selyss (but with stockfish). This is the stack trace I got:

[@mantine/core] Duplicate options are not supported. Option with value "/usr/games/stockfish" was provided more than once
fle@tauri://localhost/assets/index.js:83:140346
hle@tauri://localhost/assets/index.js:83:141500
PI@tauri://localhost/assets/index.js:38:19577
boe@tauri://localhost/assets/index.js:40:44193
goe@tauri://localhost/assets/index.js:40:39897
W9e@tauri://localhost/assets/index.js:40:39820
Cy@tauri://localhost/assets/index.js:40:39669
$O@tauri://localhost/assets/index.js:40:36024
aW@tauri://localhost/assets/index.js:40:36829
aW@[native code]
Z1@tauri://localhost/assets/index.js:38:3293
Ud@tauri://localhost/assets/index.js:40:37277
Bae@tauri://localhost/assets/index.js:37:9080
eT@tauri://localhost/assets/index.js:37:33364
gI@tauri://localhost/assets/index.js:37:17458
Ove@tauri://localhost/assets/index.js:37:17241
Ove@[native code]

franciscoBSalgueiro / en-croissant