search

franciscoBSalgueiro / en-croissant

The Ultimate Chess Toolkit
https://encroissant.org
GNU General Public License v3.0
592 stars 75 forks source link

Please sign and notarize En Croissant on macOS #309

Open karimbenbourenane opened 4 months ago

karimbenbourenane commented 4 months ago

As it currently stands, installing and running En Croissant on macOS results in a warning by Gatekeeper that the software is not signed. This requires the user to open their System Preferences, navigating to Privacy & Security, and clicking the appropriate button underneath the Security section to allow the application to be opened for the first time.

While the lack of signing doesn't prevent the software from running (albeit with some hoops to jump through), it does make it impossible to include it in the Homebrew package manager. I've created a formula to install this package as a Homebrew cask, but will need signing and notarization to be done for their maintainers to accept my pull request.

If satisfying this request is feasible, I can proceed with submitting my pull request to the Homebrew maintainers. Thanks for your attention to this matter.

Discussed in https://github.com/franciscoBSalgueiro/en-croissant/discussions/308

Originally posted by **karimbenbourenane** May 24, 2024 Hello, I have created a Homebrew cask formula for En Croissant so that it may be added to the Homebrew package manager. You can see the proposed formula here: https://github.com/karimbenbourenane/homebrew-cask/blob/en-croissant/Casks/e/en-croissant.rb Unfortunately, the formula cannot pass the audit process unless the software is signed and notarized. Would it be possible for the developers of this project to do that so I can submit the pull request to homebrew-cask? Here is the result of the audit process that noted the lack of signing and notarization: ``` ❯ brew audit --cask --new en-croissant ==> Downloading https://github.com/franciscoBSalgueiro/en-croissant/releases/dow Already downloaded: /Users/karim/Library/Caches/Homebrew/downloads/1f7795118de31263acc02b569842bb0f0b9aaccf6a65d7abc2bd5c4cd2de9e9c--en-croissant_0.10.0_x64.dmg ==> Downloading and extracting artifacts ==> Downloading https://github.com/franciscoBSalgueiro/en-croissant/releases/dow Already downloaded: /Users/karim/Library/Caches/Homebrew/downloads/1f7795118de31263acc02b569842bb0f0b9aaccf6a65d7abc2bd5c4cd2de9e9c--en-croissant_0.10.0_x64.dmg audit for en-croissant: failed - Signature verification failed: /private/tmp/cask-audit20240524-55062-n8b9a8/en-croissant.app: rejected macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software. - Upstream defined :high_sierra as the minimum OS version and the cask defined no minimum OS version en-croissant * line 5, col 2: Signature verification failed: /private/tmp/cask-audit20240524-55062-n8b9a8/en-croissant.app: rejected macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software. * Upstream defined :high_sierra as the minimum OS version and the cask defined no minimum OS version Error: 2 problems in 1 cask detected. ```
karimbenbourenane commented 4 months ago

I have a brew cask formula for this ready to go, which would make the application a lot more accessible to everyone once it's installable by the most popular package manager on macOS. I just need this application signed and notarized. Is there any plan to do this soon? If not, that's ok, but I wanted to double check before giving up. It isn't worth trying to get the formula accepted by the Homebrew Cask maintainers until the application is signed and notarized. Thanks again and cheers, Karim

franciscoBSalgueiro commented 4 months ago

I'm sorry, it's probably not coming soon. It costs 100$ per year. I understand it would make the installation slightly more convenient for Mac users, but it's not a cost I can justify at this moment.

karimbenbourenane commented 4 months ago

@franciscoBSalgueiro I'd be happy to donate some funds to help cover the cost if you can add a sponsorship/donation link on the project readme and as well as the website. I think we can crowdsource the cost of this, enough people like this project and are willing to contribute to making it better. I'll throw in $20 if you can do this and maybe we can raise the rest from other people who would like to sponsor you.

franciscoBSalgueiro commented 4 months ago

Thank you. There's already a donate link in both the readme and the website. If we start getting more donations I'll definitely consider getting the Apple certificate.