franciscoBSalgueiro / en-croissant

The Ultimate Chess Toolkit
https://encroissant.org
GNU General Public License v3.0
655 stars 82 forks source link

WDL graph not created when generating report #443

Open Mauritz8 opened 1 week ago

Mauritz8 commented 1 week ago

Describe the bug

When generating a computer analysis report for a game, the WDL (win-draw-loss) graph is not created. I was able to reproduce it using both stockfish and leela chess zero.

image

Reproduction

  1. Import game from pgn
  2. Go to report tab
  3. Click generate report
  4. Choose Stockfish 17 in the popup
  5. Wait for report to finish
  6. Select the WDL graph
  7. It is not generated as expected

Platform and versions

Ubuntu 24.04

Stack trace

No response

JWilterdink commented 1 week ago

I encountered this issue as well - it wound up being that in advanced settings for my engine, "UCI_ShowWDL" was not checked. I enabled this setting and I'm getting the WDL graph now. Maybe check for yours and see if that is the issue?

Regardless, might be good to give some sort of error message on this screen if that checkbox is not checked, or even an option to enable it right then and there. I just randomly stumbled across it, could have taken a while to find if I didn't get lucky.

Mauritz8 commented 1 week ago

That was it, thanks! Yeah I think showing an error message would be helpful. Though, having it enabled by default seems like the easiest way to fix it.