franciscoadasme / chem.cr

Library for dealing with computational chemistry files
https://franciscoadasme.github.io/chem.cr/
MIT License
23 stars 1 forks source link

Standardize transformation methods among spatial objects #186

Closed franciscoadasme closed 1 year ago

franciscoadasme commented 2 years ago

Right now, spatial objects like Vec3, AffineTransform, and CoordinatesProxy do not share the same API regarding spatial operations, where some have several transformation methods like #translate, #rotate, etc., but others don't. Also, there is the issue that some have the bang (!) variants only (CoordinatesProxy has only #transform!, but Vec3 has #transform). This can easily lead to confusion. Better to standardize all the objects to share the same API.