franciscobmacedo / remotefreelancept

Simulator for freelancers working for foreign companies while living in Portugal. Estimate your net income and taxes to pay
https://freelancept.fmacedo.com
MIT License
232 stars 34 forks source link

Change taxable income to always consider specific deductions #18

Closed joseabernardes closed 10 months ago

joseabernardes commented 11 months ago

Hi y'all,

I've created this PR because I think that the taxable income calculation was not accurate, for the cases were the user doesn't have expenses. In that case, the taxable income was calculated with the 0,9 coefficient, and the specific deductions were ignored.

I recorded a small video to showcase the problem https://github.com/franciscobmacedo/remotefreelancept/assets/24415119/3eb74eb7-ec83-4592-a27d-557a54f55fe4

Anything just reach out!

And thanks for the fantastic work @franciscobmacedo!!

franciscobmacedo commented 11 months ago

Thanks!

Are you sure about this? Could you point me to some example you found online? I haven't been using this for a while and I'm not sure if that's the case.

I think this is also proves that we need some tests to make this calculations clear - I'll create an issue for that!

joseabernardes commented 11 months ago

I was going over this with my accountant and we both found strange that, adding 1€ as expenses would decrease the taxable income in 9001€ (being 9000€ the specific deductions in our use case). As I stated above, that's because the code was ignoring the specific deductions when the user doesn't provide any expense. This article explains very well the expense handling in "simplified accounting system". https://www.montepio.org/ei/pessoal/impostos/regime-simplificado-como-funciona-a-justificacao-de-despesas/