search

franciscofranco / mako

Nexus 4
Other
95 stars 87 forks source link

DT2W #8

Closed McKael closed 6 years ago

McKael commented 10 years ago

These commits greatly improve doubletap-to-wake on the Nexus 4.

I've tried to separate each change in their own changesets so that they should be easier to review.

franciscofranco commented 10 years ago

I'm not sure I want to revisit this feature agai as it causes more trouble than its worth. How is this working for you?

— Sent from Mailbox

On Thu, Apr 10, 2014 at 12:08 AM, Mikael notifications@github.com wrote:

These commits greatly improve doubletap-to-wake on the Nexus 4. I've tried to separate each change in their own changeset so that it should be easier to review. You can merge this Pull Request by running: git pull https://github.com/McKael/FrancoKernel-mako dt2w Or you can view, comment on it, or merge it online at: https://github.com/franciscofranco/mako/pull/8 -- Commit Summary --

  • lge_touch_core.c: Fix broken indent
  • dt2w: Fix touchpad not working if dt2w is enabled when the screen is off
  • dt2w: Fix detection of double touch
  • dt2w: Add a parameter to control the doubletap_to_wake timeout value
  • dt2w: Add an option to disable d2tw when the power button is used
  • dt2w: Restrict the touchscreen area used to wake up the device
  • dt2w: Add option to use the whole screen for dt2w
  • dt2w: Add an option to enable doubletap2wake when on charger
  • dt2w: Release TS events before suspend and on resume

  • lge_touch_core: i2c_read: retry a few times before erroring out -- File Changes -- M drivers/input/misc/pmic8xxx-pwrkey.c (3) M drivers/input/touchscreen/lge_touch_core.c (168) M include/linux/input/pmic8xxx-pwrkey.h (2) -- Patch Links -- https://github.com/franciscofranco/mako/pull/8.patch https://github.com/franciscofranco/mako/pull/8.diff

    Reply to this email directly or view it on GitHub: https://github.com/franciscofranco/mako/pull/8

lkv1988 commented 10 years ago

@franciscofranco "more trouble" you mean?

McKael commented 10 years ago

Hi Francisco,

It's working fine for me so far.

What kind of trouble did you experience with dt2w? I don't think there's a high risk if you merge this patchset: if the dt2w feature is disabled it won't change anything, and if it's enabled... well, for me it really does work much better then before.

And it's even possible to only enable it when the charger is detected (Cable or Qi), i.e. no-battery-drain mode.

I have posted a boot image in the FK N4 forum, so we can wait for feedback and see if it works for people with different usage patterns...

Mikael

franciscofranco commented 10 years ago

The feature itself is problematic, this digitizer wasn't made to be left active, but I'll look at the code and ship it to see users feedback.

— Sent from Mailbox

On Thu, Apr 10, 2014 at 8:58 AM, Mikael notifications@github.com wrote:

  • Francisco Franco notifications@github.com [2014-04-10 02:00 +0200]:

    I'm not sure I want to revisit this feature agai as it causes more trouble than its worth. How is this working for you? Hi Francisco, It's working fine for me so far. What kind of trouble did you experience with dt2w? I don't think there's a high risk if you merge this patchset: if the dt2w feature is disabled it won't change anything, and if it's enabled... well, for me it really does work much better then before. And it's even possible to only enable it when the charger is detected (Cable or Qi), i.e. no-battery-drain mode. I have posted a boot image in the FK N4 forum, so we can wait for feedback and see if it works for people with different usage patterns... -- Mikael

    Reply to this email directly or view it on GitHub: https://github.com/franciscofranco/mako/pull/8#issuecomment-40052248

McKael commented 10 years ago

Thanks... You'll probably have much more feedback :-)

FWIW, I've been using it for a few days now and no problems so far.

Mikael