search

franciscogouveia / hapi-rbac

RBAC (Rule Based Access Control) for hapijs
ISC License
105 stars 20 forks source link

feat: Implement HAPI17 support #41

Closed Romakita closed 5 years ago

Romakita commented 5 years ago

BREAKING CHANGE: This plugin doesn't support HAPI v16. Callback are removed in favor of promise.

Romakita commented 5 years ago

Hello @franciscogouveia Thanks for your plugin and your work :) See you Romain

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 92.793% when pulling 520db38d76f4cfe0bb0d9e6c6fec5bf194b8f1b5 on Romakita:add-hapi17-support into 582c860fda6c8fe643bd748000dde32e33861fb1 on franciscogouveia:master.

Romakita commented 5 years ago

Hello @franciscogouveia Thanks for you work :D I fixed issues with the travis-ci configuration. Can you take a time to review this PR, please :) ? I used your plugins in big project and it should be great to have a new version that support HAPI17

See you Romain

yadomi commented 5 years ago

@franciscogouveia Any news on this ?

nazreen commented 5 years ago

@franciscogouveia

franciscogouveia commented 5 years ago

Sorry guys it took so long, I've been a bit too busy. Thank you very much for this contribution!