search

franciscogouveia / hapi-rbac

RBAC (Rule Based Access Control) for hapijs
ISC License
105 stars 20 forks source link

Improved ci #5

Closed AdrieanKhisbe closed 8 years ago

AdrieanKhisbe commented 8 years ago

setup coveralls and ci.

franciscogouveia commented 8 years ago

Thank you! This looks great

AdrieanKhisbe commented 8 years ago

you're welcome. :)

would you be interested to drop Grunt, to use a npm only build? :smiley:

franciscogouveia commented 8 years ago

Sounds good :) if npm can do it, grunt becomes obsolete. I would happily merge a PR on that. I will open an issue.

AdrieanKhisbe commented 8 years ago

great :)

AdrieanKhisbe commented 8 years ago

Few questions around:

AdrieanKhisbe commented 8 years ago

(waiting your input for this :) )

franciscogouveia commented 8 years ago

would you consider dropping support for node < 4 to use latest hapies&co?

Yes, definitely. We should encourage to move away from old node 0.x versions.

would you accept using standard hapi style?

Not only accept, I want to :D

Thank you for your time and effort!

AdrieanKhisbe commented 8 years ago

You're welcome :)

AdrieanKhisbe commented 8 years ago

(by the way, could you log to coveralls.io to activate repo?)