handle nested shell in tmux

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.

MIT License

766 stars 70 forks source link

handle nested shell in tmux #105

Closed peng1999 closed 3 years ago

peng1999 commented 3 years ago

Currently the script does not work in nested shells in tmux. This change repeatedly find the parent process id until the parent is tmux.

franciscolourenco commented 3 years ago

@peng1999 Thank you for the contribution. I've merged a new PR and now there are some conflicts. Would you mind addressing those before I merge? Thanks!

peng1999 commented 3 years ago

@franciscolourenco PR is updated. This PR completely overrides the changes of #107, but It handles more situation (nested fish process) and should works across fish versions.

franciscolourenco commented 3 years ago

@peng1999 Thank you for the contribution