allow a customized list of commands to skip

franciscolourenco / done

A fish-shell package to automatically receive notifications when long processes finish.

MIT License

770 stars 70 forks source link

allow a customized list of commands to skip #11

Closed AaronLasseigne closed 7 years ago

AaronLasseigne commented 7 years ago

I see that it has an internal list of commands to skip but it would be great if we could add to the list.

franciscolourenco commented 7 years ago

@AaronLasseigne which operative system are you using?

AaronLasseigne commented 7 years ago

I'm in iTerm2 on OSX 10.12.3. 915cb64 doesn't resolve the issue for me. If I open vim, wait more than 10 seconds, and then close it I get a notification. Originally I had requested this because I've added a custom command to launch my editor (neovim) with certain options. I was wanting to ignore my custom command.

franciscolourenco commented 7 years ago

The plugin is broken now and is not event supposed to send any notifications. I will let you know when its fixed so you can test it again. Thank you for your feedback.

franciscolourenco commented 7 years ago

@AaronLasseigne can you please test v1.0.0? It should be fixed. Make sure you have fish >2.3.0 installed. Thanks!

AaronLasseigne commented 7 years ago

I'm still having some issues but I've corrected them with #13.

franciscolourenco commented 7 years ago

Merged, thanks!